netdev - Re: [PATCH net] selinux: fix random read in selinux_ip_postroute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151105.164613.618044250901993825.davem@davemloft.net>
Date:	Thu, 05 Nov 2015 16:46:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	dvyukov@...gle.com, netdev@...r.kernel.org, paul@...l-moore.com
Subject: Re: [PATCH net] selinux: fix random read in
 selinux_ip_postroute_compat()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 05 Nov 2015 13:39:24 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> In commit e446f9dfe17b ("net: synack packets can be attached to request
> sockets"), I missed one remaining case of invalid skb->sk->sk_security
> access.
> 
> Dmitry Vyukov got a KASan report pointing to it.
> 
> Add selinux_skb_sk() helper that is responsible to get back to the
> listener if skb is attached to a request socket, instead of
> duplicating the logic.
> 
> Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Cc: Paul Moore <paul@...l-moore.com>

Looks good, applied, thanks Eric!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html