netdev - Re: [PATCH v2 1/4] ipv4: add option to drop unicast encapsulated in L2 multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1511051017220.1651@ja.home.ssi.bg>
Date:	Thu, 5 Nov 2015 10:25:01 +0200 (EET)
From:	Julian Anastasov <ja@....bg>
To:	Johannes Berg <johannes@...solutions.net>
cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/4] ipv4: add option to drop unicast encapsulated in
 L2 multicast


	Hello,

On Wed, 4 Nov 2015, Johannes Berg wrote:

> On Wed, 2015-11-04 at 22:59 +0200, Julian Anastasov wrote:
> > 
> >         } else if (unlikely(skb->pkt_type != PACKET_HOST)) {
> > 
> >         May be such check can save some cycles because
> > it is more common to see PACKET_HOST packets...
> 
> I had thought about that based on your earlier comments, but then I
> didn't quite see the point. However, perhaps we could invert the check
> below to check the pkt_type first, hoping it'll have some kind of cache
> effect?

	Yes, looks like it would be better if the checks
are reordered, the IN_DEV_* methods look more complex recently.

Regards

--
Julian Anastasov <ja@....bg>