netdev - RE: [patch -next] qlogic: qed: fix error codes in qed_resc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B5657A6538887040AD3A81F1008BEC63E6BC48@avmb3.qlogic.org>
Date:	Thu, 5 Nov 2015 09:01:08 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Ariel Elior <Ariel.Elior@...gic.com>,
	Dept-Eng Everest Linux L2 <everest-linux-l2@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch -next] qlogic: qed: fix error codes in qed_resc_alloc()

> We accidentally return success instead of -ENOMEM here.
> 
> Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>

Thanks. Although you might also argue that it's good enough for this function
to always return -ENOMEM [given it's a resource allocation functions]
instead of bothering with setting 'rc' with correct error codes.

Regardless,
Acked-by: Yuval Mintz <Yuval.Mintz@...gic.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html