| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1446809194-25993-1-git-send-email-geert@linux-m68k.org> Date: Fri, 6 Nov 2015 12:26:34 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Lauro Ramos Venancio <lauro.venancio@...nbossa.org>, Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>, Samuel Ortiz <sameo@...ux.intel.com>, Christophe Ricard <christophe.ricard@...il.com> Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, Geert Uytterhoeven <geert@...ux-m68k.org> Subject: [PATCH] NFC: nci: Fix error check of nci_hci_create_pipe() result net/nfc/nci/hci.c: In function ‘nci_hci_connect_gate’: net/nfc/nci/hci.c:679: warning: comparison is always false due to limited range of data type In case of error, nci_hci_create_pipe() returns NCI_HCI_INVALID_PIPE, and not a negative error code. Correct the check to fix this. Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> --- net/nfc/nci/hci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c index 2aedac15cb592353..a0ab26d535dca749 100644 --- a/net/nfc/nci/hci.c +++ b/net/nfc/nci/hci.c @@ -676,7 +676,7 @@ int nci_hci_connect_gate(struct nci_dev *ndev, break; default: pipe = nci_hci_create_pipe(ndev, dest_host, dest_gate, &r); - if (pipe < 0) + if (pipe == NCI_HCI_INVALID_PIPE) return r; pipe_created = true; break; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists