netdev - Re: [PATCH] inet: delay address promotion check until last request in message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1511062352270.1904@ja.home.ssi.bg>
Date:	Sat, 7 Nov 2015 01:49:25 +0200 (EET)
From:	Julian Anastasov <ja@....bg>
To:	Neil Horman <nhorman@...driver.com>
cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH] inet: delay address promotion check until last request
 in message


	Hello,

On Fri, 6 Nov 2015, Neil Horman wrote:

> The solution is to recognize that its pointless to promote an address to be a
> new primary, if there is a possibility that it will just be removed in the near
> future.  As such this patch peeks ahead to the next request in the provided
> netlink message, and, if it is both valid and a RTM_DELADDR request, skips the
> promotion check.  This eliminates the need to iterate through a nested for loop

	flush can provide many parameters. As there is no
any kind of indication in the netlink message that all addresses
are removed, we can not avoid the promotion.

> +	 * Only check for address promotion when this is the last request
> +	 * in this netlink transaction.  It allows this operation to complete
> +	 * in O(n) time rather than O(n^2)

	It is not correct to assume that one promotion per
transaction is enough. The promotion happens in every subnet,
it was not once per device.

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html