[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20151106.233311.2260896695923603885.davem@davemloft.net>
Date: Fri, 06 Nov 2015 23:33:11 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: elfring@...rs.sourceforge.net
Cc: lars.persson@...s.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
julia.lawall@...6.fr
Subject: Re: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before
the function call "of_node_put"
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
Date: Fri, 6 Nov 2015 08:15:30 +0100
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 6 Nov 2015 08:00:22 +0100
>
> The of_node_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
Please resubmit this with a more appropriate Subject line.
The subsystem prefix should be all lower-case and typically
indicate the most specific subsystem or area being changed.
In this case it's a driver, therefore simply use the driver
name "dwc_eth_qos: ".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists