netdev - Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151107.095013.902059569721693135.davem@davemloft.net>
Date:	Sat, 07 Nov 2015 09:50:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	elfring@...rs.sourceforge.net
Cc:	lars.persson@...s.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before
 of_node_put()

From: SF Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 7 Nov 2015 15:15:24 +0100

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 7 Nov 2015 15:10:29 +0100
> 
> The of_node_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

As I requested of you last night, please phrase the subsystem
prefix of your Subject lines more correctly.

Just use the driver's name, in lower case, as one single word,
which in this case would be "dwc_eth_qos: ".

I'm telling you exactly what to use in the Subject line, there
is no ambiguity or confusion on what you need to do for me to
accept this patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html