netdev - Re: [PATCH] macvtap: Resolve possible __might_sleep warning in macvtap_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151109.120516.1822300207198042759.davem@davemloft.net>
Date:	Mon, 09 Nov 2015 12:05:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vyasevich@...il.com
Cc:	netdev@...r.kernel.org, jasowang@...hat.com, mst@...hat.com,
	vyasevic@...hat.com
Subject: Re: [PATCH] macvtap: Resolve possible __might_sleep warning in
 macvtap_do_read()

From: Vladislav Yasevich <vyasevich@...il.com>
Date: Mon,  9 Nov 2015 09:14:17 -0500

> macvtap_do_read code calls macvtap_put_user while it might be set up
> to wait for the user.  This results in the following warning:
 ...
> Make sure thet we call finish_wait() if we have the skb to process
> before trying to actually process it.
> 
> Signed-off-by: Vladislav Yasevich <vyasevic@...hat.com>

Oh I see, this is that new check in might_sleep() that makes sure
that the task state is TASK_RUNNING.

Looks good, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html