[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20151109.132523.624907753522887529.davem@davemloft.net>
Date: Mon, 09 Nov 2015 13:25:23 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: rweikusat@...ileactivedefense.com
Cc: jbaron@...mai.com, dvyukov@...gle.com, syzkaller@...glegroups.com,
mkubecek@...e.cz, viro@...iv.linux.org.uk,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
hannes@...essinduktion.org, dhowells@...hat.com,
paul@...l-moore.com, salyzyn@...roid.com, sds@...ho.nsa.gov,
ying.xue@...driver.com, netdev@...r.kernel.org, kcc@...gle.com,
glider@...gle.com, andreyknvl@...gle.com, sasha.levin@...cle.com,
jln@...gle.com, keescook@...gle.com, minipli@...glemail.com
Subject: Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue
From: Rainer Weikusat <rweikusat@...ileactivedefense.com>
Date: Mon, 09 Nov 2015 14:40:48 +0000
> + __remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wait,
> + &u->peer_wake);
This is more simply:
__remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wait, q);
> +static inline int unix_dgram_peer_recv_ready(struct sock *sk,
> + struct sock *other)
Please do not us the inline keyword in foo.c files, let the compiler
decide.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists