netdev - Re: [PATCH] drivers: net: cpsw: add support for fixed-links.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Nov 2015 22:47:39 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dtrautmann@...softec.com
Cc:	netdev@...r.kernel.org, mugunthanvnm@...com, balbi@...com
Subject: Re: [PATCH] drivers: net: cpsw: add support for fixed-links.

From: Daniel Trautmann <dtrautmann@...softec.com>
Date: Mon, 9 Nov 2015 20:24:14 +0100

> @@ -2039,19 +2039,35 @@ static int cpsw_probe_dt(struct cpsw_priv *priv,
>  		priv->phy_node = of_parse_phandle(slave_node, "phy-handle", 0);
>  		parp = of_get_property(slave_node, "phy_id", &lenp);
>  		if ((parp == NULL) || (lenp != (sizeof(void *) * 2))) {
> -			dev_err(&pdev->dev, "Missing slave[%d] phy_id property\n", i);

I know this has nothing to do with your patch, but that length check
is completely bogus.

It should be "sizeof(__be32) * 2" not "sizeof(void *) * 2".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html