netdev - Re: [PATCH] Revert "bridge: Allow forward delay to be cfgd when STP enabled"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151110.154219.28142723661620451.davem@davemloft.net>
Date:	Tue, 10 Nov 2015 15:42:19 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vyasevich@...il.com
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	vyasevic@...hat.com
Subject: Re: [PATCH] Revert "bridge: Allow forward delay to be cfgd when
 STP enabled"

From: Vladislav Yasevich <vyasevich@...il.com>
Date: Tue, 10 Nov 2015 06:15:32 -0500

> This reverts commit 34c2d9fb0498c066afbe610b15e18995fd8be792.
> 
> There are 2 reasons for this revert:
>  1)  The commit in question doesn't do what it says it does.  The
>      description reads: "Allow bridge forward delay to be configured
>      when Spanning Tree is enabled."  This was already the case before
>      the commit was made.  What the commit actually do was disallow
>      invalid values or 'forward_delay' when STP was turned off.
> 
>  2)  The above change was actually a change in the user observed
>      behavior and broke things like libvirt and other network configs
>      that set 'forward_delay' to 0 without enabling STP.  The value
>      of 0 is actually used when STP is turned off to immediately mark
>      the bridge as forwarding.
> 
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>

Fair enough, applied, thanks Vlad.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html