netdev - Re: [net-next PATCH 2/3] ixgbe: Use __dev_uc_sync and __dev_uc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151111173557.6eb25df5@xeon-e3>
Date:	Wed, 11 Nov 2015 17:35:57 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Alexander Duyck <aduyck@...antis.com>
Cc:	netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
	jeffrey.t.kirsher@...el.com
Subject: Re: [net-next PATCH 2/3] ixgbe: Use __dev_uc_sync and
 __dev_uc_unsync for unicast addresses

On Thu, 22 Oct 2015 16:26:36 -0700
Alexander Duyck <aduyck@...antis.com> wrote:

> +static int ixgbe_uc_unsync(struct net_device *netdev, const unsigned char *addr)
> +{
> +	struct ixgbe_adapter *adapter = netdev_priv(netdev);
> +
> +	ixgbe_del_mac_filter(adapter, addr, VMDQ_P(0));
> +
> +	return 0;

Why add an internal function that always returns 0?
Rather than making it void.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html