netdev - Re: [PATCH v2] stmmac: avoid ipq806x constant overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151112.161221.471436899716074817.davem@davemloft.net>
Date:	Thu, 12 Nov 2015 16:12:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	mathieu@...eaurora.org, linux-kernel@...r.kernel.org,
	peppe.cavallaro@...com
Subject: Re: [PATCH v2] stmmac: avoid ipq806x constant overflow warning

From: Arnd Bergmann <arnd@...db.de>
Date: Thu, 12 Nov 2015 22:03:40 +0100

> @@ -337,11 +337,11 @@ static int ipq806x_gmac_probe(struct platform_device *pdev)
>  			     QSGMII_PHY_RX_SIGNAL_DETECT_EN |
>  			     QSGMII_PHY_TX_DRIVER_EN |
>  			     QSGMII_PHY_QSGMII_EN |
> -			     0x4 << QSGMII_PHY_PHASE_LOOP_GAIN_OFFSET |
> -			     0x3 << QSGMII_PHY_RX_DC_BIAS_OFFSET |
> -			     0x1 << QSGMII_PHY_RX_INPUT_EQU_OFFSET |
> -			     0x2 << QSGMII_PHY_CDR_PI_SLEW_OFFSET |
> -			     0xC << QSGMII_PHY_TX_DRV_AMP_OFFSET);
> +			     0x4ul << QSGMII_PHY_PHASE_LOOP_GAIN_OFFSET |
> +			     0x3ul << QSGMII_PHY_RX_DC_BIAS_OFFSET |
> +			     0x1ul << QSGMII_PHY_RX_INPUT_EQU_OFFSET |
> +			     0x2ul << QSGMII_PHY_CDR_PI_SLEW_OFFSET |
> +			     0xCul << QSGMII_PHY_TX_DRV_AMP_OFFSET);
>  	}
>  

Indeed, this looks so much better.

Applied.

Thanks for looking more deeply into this!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html