netdev - Re: [PATCH net] switchdev: bridge: Check return code is not EOPNOTSUPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151113124319.GA31426@colbert.Home>
Date:	Fri, 13 Nov 2015 14:43:19 +0200
From:	Ido Schimmel <idosch@...lanox.com>
To:	Sander Eikelenboom <linux@...elenboom.it>
CC:	<netdev@...r.kernel.org>, <stephen@...workplumber.org>,
	<davem@...emloft.net>, <eladr@...lanox.com>,
	Jiri Pirko <jiri@...lanox.com>, <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net] switchdev: bridge: Check return code is not
 EOPNOTSUPP

Fri, Nov 13, 2015 at 02:34:45PM IST, linux@...elenboom.it wrote:
>On 2015-11-13 12:06, Ido Schimmel wrote:
>> When NET_SWITCHDEV=n, switchdev_port_attr_set simply returns 
>> EOPNOTSUPP.
>> In this case we should not emit errors and warnings to the kernel log.
>
>Hi Ido,
>
>Thanks for your patch!
>
>It fixes these:
>[  207.245442] vif vif-1-0 vif1.0: failed to set HW ageing time
>[  207.245443] xen_bridge: error setting offload STP state on 
>port1(vif1.0)
>
>But i still have these:
>[  335.412194] vif19.0-emu: set_features() failed (-1); wanted 
>0x00000080000048c1, left 0x00000080001b48c9
>[  335.412204] vif19.0-emu: set_features() failed (-1); wanted 
>0x00000080000048c1, left 0x00000080001b48c9
>[  335.412311] vif19.0-emu: set_features() failed (-1); wanted 
>0x00000080000248c9, left 0x00000080001b48c9
>[  335.412319] vif19.0-emu: set_features() failed (-1); wanted 
>0x00000080000048c1, left 0x00000080001b48c9
>[  335.412326] vif19.0-emu: set_features() failed (-1); wanted 
>0x00000080000048c1, left 0x00000080001b48c9
>[  335.535955] vif vif-19-0 vif19.0: set_features() failed (-1); wanted 
>0x0000000400004803, left 0x0000000400114813
>[  335.535965] vif vif-19-0 vif19.0: set_features() failed (-1); wanted 
>0x0000000400004803, left 0x0000000400114813
>[  335.615392] vif vif-19-0 vif19.0: set_features() failed (-1); wanted 
>0x0000000400004803, left 0x0000000400114813
>[  335.615401] xen_bridge: set_features() failed (-1); wanted 
>0x000000801fdb78c9, left 0x000000801fff78e9
>

Yes, this is a different issue and I see that Nik is already working on
it. Can you please try his patch?

http://patchwork.ozlabs.org/patch/544242/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html