netdev - Re: [PATCH net] net: fix feature changes on devices without ndo_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Nov 2015 09:34:28 -0500
From:	Jarod Wilson <jarod@...hat.com>
To:	Nikolay Aleksandrov <razor@...ckwall.org>
CC:	netdev@...r.kernel.org, davem@...emloft.net,
	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Ido Schimmel <idosch@...lanox.com>,
	Sander Eikelenboom <linux@...elenboom.it>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov<nikolay@...ulusnetworks.com>
>
> When __netdev_update_features() was updated to ensure some features are
> disabled on new lower devices, an error was introduced for devices which
> don't have the ndo_set_features() method set. Before we'll just set the
> new features, but now we return an error and don't set them. Fix this by
> returning the old behaviour and setting err to 0 when ndo_set_features
> is not present.
>
> Fixes: e7868a85e1b2 ("net/core: ensure features get disabled on new lower devs")
> CC: Jarod Wilson<jarod@...hat.com>
> CC: Jiri Pirko<jiri@...nulli.us>
> CC: Ido Schimmel<idosch@...lanox.com>
> CC: Sander Eikelenboom<linux@...elenboom.it>
> CC: Andy Gospodarek<gospo@...ulusnetworks.com>
> CC: Florian Fainelli<f.fainelli@...il.com>
> Signed-off-by: Nikolay Aleksandrov<nikolay@...ulusnetworks.com>
> ---
> Sander please feel free to give your Tested-by.

Ah, good catch, thank you for cleaning up my mess.

Reviewed-by: Jarod Wilson <jarod@...hat.com>

-- 
Jarod Wilson
jarod@...hat.com


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html