netdev - Re: [PATCH net] rtnetlink: fix frame size warning in rtnl_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151116.153837.635003227845494331.davem@davemloft.net>
Date:	Mon, 16 Nov 2015 15:38:37 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] rtnetlink: fix frame size warning in
 rtnl_fill_ifinfo

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Mon, 16 Nov 2015 12:05:03 +0100

> By declaring the huge stack allocations as static. We can do so
> because we hold rtnl.

Look across the tree, this is an idiom copied all over the place.
If putting a rtnl_link_stats64 object on the stack is truly a
problem, we have a lot of spots to fix.

I do not think, therefore, that this solution is tenable, we
need something that handles all cases properly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html