netdev - RE: [PATCH] net: thunder: Fix crash upon shutdown after failed probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Nov 2015 16:21:06 +0300
From:	Pavel Fedin <p.fedin@...sung.com>
To:	'David Miller' <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, sgoutham@...ium.com, rric@...nel.org,
	youngmin.lee@...ium.com, kin-yip.liu@...ium.com
Subject: RE: [PATCH] net: thunder: Fix crash upon shutdown after failed probe

 Hello!

> > If device probe fails, driver remains bound to the PCI device. However,
> > driver data has been reset to NULL. This causes crash upon dereferencing
> > it in nicvf_remove()
> >
> > Signed-off-by: Pavel Fedin <p.fedin@...sung.com>
> 
> Applied, thanks.

 Thank you very much, however i've just found one more case where i still get this crash. I should have done this from the
beginning, but please revert it in your repo, i'm sending v2, which covers more cases.
 The new case is feeding the device to vfio after the probe failed. In this case nicvf_remove() is called upon unbind.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html