lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Nov 2015 14:46:40 +0100 From: Stefan Schmidt <stefan@....samsung.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net>, Alexander Aring <alex.aring@...il.com>, linux-wpan@...r.kernel.org, netdev@...r.kernel.org Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" Hello. On 16/11/15 13:57, SF Markus Elfring wrote: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Mon, 16 Nov 2015 13:50:23 +0100 > > The kfree_skb() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> > --- > drivers/net/ieee802154/atusb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c > index 199a94a..b1cd865 100644 > --- a/drivers/net/ieee802154/atusb.c > +++ b/drivers/net/ieee802154/atusb.c > @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb) > urb = usb_get_from_anchor(&atusb->idle_urbs); > if (!urb) > break; > - if (urb->context) > - kfree_skb(urb->context); > + kfree_skb(urb->context); > usb_free_urb(urb); > } > } Acked-by: Stefan Schmidt <stefan@....samsung.com> regards Stefan Schmidt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists