[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <77EF4405DD4BB54AACCE7DB593DF6A9AA08010@SJEXCHMB14.corp.ad.broadcom.com>
Date: Mon, 16 Nov 2015 06:12:24 +0000
From: Premkumar Jonnala <pjonnala@...adcom.com>
To: David Miller <davem@...emloft.net>,
"f.fainelli@...il.com" <f.fainelli@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"sfeldma@...il.com" <sfeldma@...il.com>,
"jiri@...nulli.us" <jiri@...nulli.us>,
"nikolay@...ulusnetworks.com" <nikolay@...ulusnetworks.com>,
"idosch@...lanox.com" <idosch@...lanox.com>,
"gospo@...ulusnetworks.com" <gospo@...ulusnetworks.com>
Subject: RE: [PATCH] bonding: Offloading bonds to hardware
> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Saturday, November 14, 2015 12:40 AM
> To: f.fainelli@...il.com
> Cc: Premkumar Jonnala; netdev@...r.kernel.org; sfeldma@...il.com;
> jiri@...nulli.us; nikolay@...ulusnetworks.com; idosch@...lanox.com;
> gospo@...ulusnetworks.com
> Subject: Re: [PATCH] bonding: Offloading bonds to hardware
>
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Fri, 13 Nov 2015 10:38:48 -0800
>
> > This is a good explanation of why you want the changes, and how this is
> > implemented in a system utilizing that, but this is not documenting why
> > you are making these changes to the bonding code, nor how they are
> > supposed to be used by an implementor driver, since there is no such
> > user posted (yet?).
>
> I am basically not even going to look at proposals for new device ops
> that don't also show an actual user of the new interfaces.
>
> That's not how we do development, and not providing a real example
> user of a new set of interfaces makes it impossible to properly review
> such changes.
Thank you for the feedback David. I am currently handling/implementing
these notifications in a custom (closed source) driver. I will update the diff
with an actual demo of the handler, and resend the diffs.
Thanks
Prem
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists