netdev - RE: [PATCH] bonding: Offloading bonds to hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77EF4405DD4BB54AACCE7DB593DF6A9AA0903F@SJEXCHMB14.corp.ad.broadcom.com>
Date:	Mon, 16 Nov 2015 06:48:34 +0000
From:	Premkumar Jonnala <pjonnala@...adcom.com>
To:	Jiri Pirko <jiri@...nulli.us>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"idosch@...lanox.com" <idosch@...lanox.com>,
	"nikolay@...ulusnetworks.com" <nikolay@...ulusnetworks.com>,
	"sfeldma@...il.com" <sfeldma@...il.com>,
	"gospo@...ulusnetworks.com" <gospo@...ulusnetworks.com>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [PATCH] bonding: Offloading bonds to hardware

> 
> Thu, Nov 12, 2015 at 05:02:18PM CET, pjonnala@...adcom.com wrote:
> >Packet forwarding to/from bond interfaces is done in software.
> >
> >This patch enables certain platforms to bridge traffic to/from
> >bond interfaces in hardware.  Notifications are sent out when
> >the "active" slave set for a bond interface is updated in
> >software.  Platforms use the notifications to program the
> >hardware accordingly.  The changes have been verified to work
> >with configured and 802.3ad bond interfaces.
> >
> >Signed-off-by: Premkumar Jonnala <pjonnala@...adcom.com>

Thank you for the comments Jiri.

> This patch is wrong, in many different acpects. Leaving the submission
> style, and no in-tree consumer aside, adding ndos for this thing is
> unacceptable. It should be handled as a part of switchdev attrs.
> Also, the solution should not be bonding-centric.

Can you elaborate on how you envision the solution to be, when you say 
the solution should not be "bonding centric"?

Thanks
Prem

> 
> I have a patchset in my queue which does this correctly, for bond and team
> using switchdev attr and with actual in-tree consumer, mlxsw driver.
> I plan to send that soon after net-next opens.
> 
> Jiri
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html