netdev - Re: [PATCH net] net: fix __netdev_update_features return on ndo_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151116.145640.946535191930162699.davem@davemloft.net>
Date:	Mon, 16 Nov 2015 14:56:40 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	netdev@...r.kernel.org, nikolay@...ulusnetworks.com,
	mirq-linux@...e.qmqm.pl
Subject: Re: [PATCH net] net: fix __netdev_update_features return on
 ndo_set_features failure

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Fri, 13 Nov 2015 15:20:24 +0100

> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> If ndo_set_features fails __netdev_update_features() will return -1 but
> this is wrong because it is expected to return 0 if no features were
> changed (see netdev_update_features()), which will cause a netdev
> notifier to be called without any actual changes. Fix this by returning
> 0 if ndo_set_features fails.
> 
> Fixes: 6cb6a27c45ce ("net: Call netdev_features_change() from netdev_update_features()")
> CC: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html