netdev - Re: [PATCH net] net/core: revert "net: fix __netdev_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151117.152723.1710661109450916935.davem@davemloft.net>
Date:	Tue, 17 Nov 2015 15:27:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	netdev@...r.kernel.org, nikolay@...ulusnetworks.com,
	mirq-linux@...e.qmqm.pl
Subject: Re: [PATCH net] net/core: revert "net: fix
 __netdev_update_features return.." and add comment

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Tue, 17 Nov 2015 15:49:06 +0100

> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> This reverts commit 00ee59271777 ("net: fix __netdev_update_features return
> on ndo_set_features failure")
> and adds a comment explaining why it's okay to return a value other than
> 0 upon error. Some drivers might actually change flags and return an
> error so it's better to fire a spurious notification rather than miss
> these.
> 
> CC: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
> Thanks to Michal for the explanation on why it was made to act like that.
> Also sorry for the noise, unfortunately I missed this. IMO this should've
> been an all or nothing op from the beginning.

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html