netdev - Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <564B1695.8000009@citrix.com>
Date:	Tue, 17 Nov 2015 11:59:17 +0000
From:	David Vrabel <david.vrabel@...rix.com>
To:	Marek Marczykowski-Górecki 
	<marmarek@...isiblethingslab.com>,
	David Vrabel <david.vrabel@...rix.com>
CC:	<netdev@...r.kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	xen-devel <xen-devel@...ts.xen.org>,
	Annie Li <annie.li@...cle.com>
Subject: Re: [Xen-devel] xen-netfront crash when detaching network while some
 network activity

On 21/10/15 19:57, Marek Marczykowski-Górecki wrote:
> 
> Any ideas?

No, sorry.  Netfront looks correct to me.

We take an additional ref for the ref released by
gnttab_release_grant_reference().  The get_page() here is safe since we
haven't freed the page yet (this is done in the subsequent call to
skb_kfree_irq()).

get_page()/put_page() also look fine when used with tail pages.

David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html