netdev - Re: [PATCH v1 net] net: use skb_clone to avoid alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1447768148.22599.93.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 17 Nov 2015 05:49:08 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	martinbj2008@...il.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Junwei Zhang <linggao.zjw@...baba-inc.com>
Subject: Re: [PATCH v1 net] net: use skb_clone to avoid alloc_pages failure.

On Tue, 2015-11-17 at 05:07 -0800, Eric Dumazet wrote:
> On Tue, 2015-11-17 at 20:49 +0800, martinbj2008@...il.com wrote:
> > From: Martin Zhang <martinbj2008@...il.com>
> > 
> > 1. new skb only need dst and ip address(v4 or v6).
> > 2. skb_copy may need high order pages, which is very rare on long running server.
> > 
> > Signed-off-by: Junwei Zhang <linggao.zjw@...baba-inc.com>
> > Signed-off-by: Martin Zhang <martinbj2008@...il.com>
> > ---
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>
> 

BTW, very nice catch, thanks guys !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html