netdev - Re: [PATCH net-next 3/9] net: un-inline sk_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1447769751.22599.95.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 17 Nov 2015 06:15:51 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Eric Dumazet <edumazet@...gle.com>
Cc:	"David S . Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Eli Cohen <eli@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>,
	Ariel Elior <ariel.elior@...gic.com>,
	Willem de Bruijn <willemb@...gle.com>,
	Rida Assaf <rida@...gle.com>
Subject: Re: [PATCH net-next 3/9] net: un-inline sk_busy_loop()

On Tue, 2015-11-17 at 05:56 -0800, Eric Dumazet wrote:
> There is really little gain from inlining this big function.
> We'll soon make it even bigger in following patches.

I forgot to guard sk_busy_poll() with appropriate #ifdef :

This will be added in v2

diff --git a/net/core/dev.c b/net/core/dev.c
index 21a7d4093fde..c87c8486ea21 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4673,6 +4673,7 @@ static struct napi_struct *napi_by_id(unsigned int napi_id)
 	return NULL;
 }
 
+#if defined(CONFIG_NET_RX_BUSY_POLL)
 #define BUSY_POLL_BUDGET 8
 bool sk_busy_loop(struct sock *sk, int nonblock)
 {
@@ -4726,6 +4727,7 @@ out:
 	return rc;
 }
 EXPORT_SYMBOL(sk_busy_loop);
+#endif
 
 void napi_hash_add(struct napi_struct *napi)
 {


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html