netdev - Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151116.205526.851300695363409790.davem@davemloft.net>
Date:	Mon, 16 Nov 2015 20:55:26 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	paul.gortmaker@...driver.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	linux-next@...r.kernel.org
Subject: Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Mon, 16 Nov 2015 20:45:25 -0500

> Just a heads up that this breaks all arm64 builds in linux-next from
> Monday; bisect says:
> 
> 00fd38d938db3f1ab1c486549afc450cb7e751b1 is the first bad commit
> commit 00fd38d938db3f1ab1c486549afc450cb7e751b1
> Author: Eric Dumazet
> <edumazet@...gle.com>http://kisskb.ellerman.id.au/kisskb/buildresult/12548450/
> Date:   Thu Nov 12 08:43:18 2015 -0800
> 
>     tcp: ensure proper barriers in lockless contexts
> 
> Here is one of the linux-next fails:
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12548450/

Thanks for the report Paul.

I think Eric's patch is correct.  I see what ARM is trying to do here,
but it really has to accomodate const arguments to smp_load_acquire().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html