netdev - Re: [PATCH net] af_unix: take receive queue lock while appending new skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1447772140.544921.442208625.2042D49B@webmail.messagingengine.com>
Date:	Tue, 17 Nov 2015 15:55:40 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] af_unix: take receive queue lock while appending new skb

Hi Eric,

On Tue, Nov 17, 2015, at 15:42, Eric Dumazet wrote:
> On Tue, 2015-11-17 at 15:10 +0100, Hannes Frederic Sowa wrote:
> > While possibly in future we don't necessarily need to use
> > sk_buff_head.lock this is a rather larger change, as it affects the
> > af_unix fd garbage collector, diag and socket cleanups. This is too much
> > for a stable patch.
> > 
> > For the time being grab sk_buff_head.lock without disabling bh and irqs,
> > so don't use locked skb_queue_tail.
> 
> I would use skb_queue_tail() as we already use it in two different
> places in af_unix.c, like unix_stream_sendmsg()
> 
> It is hardly a fast path anyway, so lets keep code short.
> 
> Then, in net-next, if you really want, add a new skb_queue_tail_lock()
> or similar helper ?

I want to move to unix_state_lock and completely drop sk_buff_head.lock
in af_unix, as such I would prefer to keep it this way as in some other
places in af_unix.c (e.g. unix_stream_connect).

Or do you have a strong opinion on that?

Thanks,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html