netdev - Re: [PATCH] via-velocity: unconditionally drop frames with bad l2 length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151117.143729.404916007454778979.davem@davemloft.net>
Date:	Tue, 17 Nov 2015 14:37:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	timo.teras@....fi
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org
Subject: Re: [PATCH] via-velocity: unconditionally drop frames with bad l2
 length

From: Timo Teräs <timo.teras@....fi>
Date: Mon, 16 Nov 2015 14:36:32 +0200

> By default the driver allowed incorrect frames to be received. What is
> worse the code does not handle very short frames correctly. The FCS
> length is unconditionally subtracted, and the underflow can cause
> skb_put to be called with large number after implicit cast to unsigned.
> And indeed, an skb_over_panic() was observed with via-velocity.
> 
> This removes the module parameter as it does not work in it's
> current state, and should be implemented via NETIF_F_RXALL if needed.
> 
> Suggested-by: Francois Romieu <romieu@...zoreil.com>
> Signed-off-by: Timo Teräs <timo.teras@....fi>

Applied, thanks Timo.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html