netdev - Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Nov 2015 11:15:45 -0700
From:	Jason Gerard DeRose <jason@...tem76.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	netdev@...r.kernel.org
Cc:	Ben Pope <benpope81@...il.com>
Subject: Re: [PATCH] ethernet/atheros/alx: add Killer E2400 device ID



On 11/18/2015 10:47 AM, Sergei Shtylyov wrote:
> On 11/18/2015 05:52 PM, Jason Gerard DeRose wrote:
>
>>>> From: Ben Pope <benpope81@...il.com>
>>>>
>>>> This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for
>>>> the
>>>> Killer E2400 Ethernet controller, modeled after the Killer E2200
>>>> controller support (0xe091) already present in the alx driver.
>>>>
>>>> This patch was originally authored by Ben Pope, but it got held up by
>>>> issues in the commit message, so I'm resubmitting it on his behalf.
>>>>
>>>> I've extensively used a kernel with this patch on a System76 serw9
>>>> laptop and am quite confident it works well (at least on the hardware I
>>>> have available for testing).
>>>>
>>>> Note that as a favor to System76, Ubuntu has been carrying this as a
>>>> sauce patch in their 4.2 based Wily kernel, which presumably has given
>>>> it real-world testing on other E2400 equipped hardware (I don't know of
>>>> any Ubuntu kernel bugs filed about it):
>>>>
>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
>>>>
>>>> Signed-off-by: Jason Gerard DeRose <jason@...tem76.com>
>>>
>>>     No sign-off from Ben?
>>
>> Apologies, this is my first time submitting a kernel patch :)
>>
>> Should I use git send-email to send this again,
>
>     I didn't notice if your mailer corrupted the patch but if it did
> 'git send-email' should be used indeed.

I originally used `git send-email`, so the patch should not have been 
corrupted.

>> this time with the sign-off from Ben?
>
>     No need to resend if it wasn't corrupted. Just replying to this
> patch with his sign-off should be enough -- patchwork should collect the
> tags from the follow-ups.

Okay, thanks for the clarification!

>> And if so, should I do so as a reply to this thread?
>
>     No, not on this list. DaveM prefers the patch reposts to be done as
> the fresh new postings.
>
>> Thanks for you time!
>
>     Your, I guess? Not at all. :-)

Also thank you for enduring my typos ;)

> MBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html