netdev - Re: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Nov 2015 11:25:56 +0100
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Wenyou Yang <wenyou.yang@...el.com>,
	Wolfgang Grandegger <wg@...ndegger.com>
Cc:	linux-can@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...el.com>
Subject: Re: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT
 accepted

On 11/18/2015 11:04 AM, Wenyou Yang wrote:
> Increase the delay time until the value written to INIT can be
> read back to ensure that the previous value written to INIT has
> been accepted.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>

The patch looks ok, can you please add to your commit message which SoCs
are affected by this problem.

> ---
> 
>  drivers/net/can/m_can/m_can.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index ef65517..fd1caa0 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -320,7 +320,7 @@ static inline void m_can_config_endisable(const struct m_can_priv *priv,
>  					  bool enable)
>  {
>  	u32 cccr = m_can_read(priv, M_CAN_CCCR);
> -	u32 timeout = 10;
> +	u32 timeout = 1000;
>  	u32 val = 0;
>  
>  	if (enable) {
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)