netdev - Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1511181623240.1381@chino.kir.corp.google.com>
Date:	Wed, 18 Nov 2015 16:23:37 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	Russell King <linux@....linux.org.uk>,
	linux-acpi@...r.kernel.org, drbd-user@...ts.linbit.com,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	codalist@...a.cs.cmu.edu, linux-mtd@...ts.infradead.org,
	Jan Kara <jack@...e.com>, linux-fsdevel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] tree wide: Use kvfree() than conditional
 kfree()/vfree()

On Mon, 9 Nov 2015, Tetsuo Handa wrote:

> There are many locations that do
> 
>   if (memory_was_allocated_by_vmalloc)
>     vfree(ptr);
>   else
>     kfree(ptr);
> 
> but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory
> using is_vmalloc_addr(). Unless callers have special reasons, we can
> replace this branch with kvfree(). Please check and reply if you found
> problems.
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Acked-by: Michal Hocko <mhocko@...e.com>
> Cc: Russell King <linux@....linux.org.uk> # arm
> Cc: <linux-acpi@...r.kernel.org> # apei
> Cc: <drbd-user@...ts.linbit.com> # drbd
> Cc: <linux-kernel@...r.kernel.org> # mspec
> Cc: <dri-devel@...ts.freedesktop.org> # drm
> Cc: Oleg Drokin <oleg.drokin@...el.com> # lustre
> Cc: Andreas Dilger <andreas.dilger@...el.com> # lustre
> Cc: <codalist@...a.cs.cmu.edu> # coda
> Cc: <linux-mtd@...ts.infradead.org> # jffs2
> Cc: Jan Kara <jack@...e.com> # udf
> Cc: <linux-fsdevel@...r.kernel.org> # xattr
> Cc: <linux-mm@...ck.org> # ipc + mm
> Cc: <netdev@...r.kernel.org> # ipv4

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html