netdev - Re: [PATCH] ravb: fix WARNING in __free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151118.220417.711975268777866760.davem@davemloft.net>
Date:	Wed, 18 Nov 2015 22:04:17 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	netdev@...r.kernel.org, linux-sh@...r.kernel.org,
	kazuya.mizuguchi.ks@...esas.com, horms+renesas@...ge.net.au
Subject: Re: [PATCH] ravb: fix WARNING in __free_irq()

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Thu, 19 Nov 2015 01:39:51 +0300

> When the R8A7795 support was  added to the driver, little attention was paid
> to the ravb_open() error path: free_irq()  for the EMAC interrupt was called
> uncoditionally, unlike request_irq(), and in  a wrong order as well...
> As a result, on the R-Car gen2 SoCs I started getting the following in case
> of a device  opening error:
 ...
> Fix up the free_irq() call order and add a new label on the error path.
> 
> Fixes: 22d4df8ff3a3 ("ravb: Add support for r8a7795 SoC")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html