netdev - Re: [PATCH net-next] net: remove useless check in napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1447965199.22599.252.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 19 Nov 2015 12:33:19 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: remove useless check in napi_gro_frags()

On Thu, 2015-11-19 at 21:20 +0100, Bjørn Mork wrote:
> Eric Dumazet <eric.dumazet@...il.com> writes:
> 
> > How many times should we crash before napi_frags_skb() returns NULL ?
> ..
> >                         return NULL;
> 
> Huh?  Now I'm lost here, too.


Well, Ethernet drivers should not feed GRO with frames with less than 14 bytes.

( eth_type_trans() would crash the same )

Lets fix buggy drivers instead of adding defensive code all over the stack.

napi_gro_frags() is used by exactly 10 drivers, and I am pretty sure they are OK.




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html