netdev - Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151119210651.GA5044@lunn.ch>
Date:	Thu, 19 Nov 2015 22:06:51 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	David Daney <ddaney.cavm@...il.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org,
	Florian Fainelli <f.fainelli@...il.com>,
	David Daney <david.daney@...ium.com>,
	Lennert Buytenhek <buytenh@...tstofly.org>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the
 bus' parent.

On Thu, Nov 19, 2015 at 11:51:37PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/22/2015 02:16 AM, David Daney wrote:
> 
> >From: David Daney <david.daney@...ium.com>
> >
> >commit 18ee49ddb0d2 ("phylib: rename mii_bus::dev to mii_bus::parent")
> >changed the parent of PHY devices from the bus to the bus parent.
> >
> >Then, commit 4dea547fef1b ("phylib: rework to prepare for OF
> >registration of PHYs") moved the code into phy_device.c
> >
> >At this point, it is somewhat unclear why the change was seen as
> >necessary.  But, when we look at the device model tree in
> >/sys/devices, it is clearly incorrect.  The PHYs should be children of
> >their MDIO bus.
> >
> >Change the PHY's parent device to be the MDIO bus device.
> >
> >Cc: Lennert Buytenhek <buytenh@...tstofly.org>
> >Cc: Grant Likely <grant.likely@...retlab.ca>
> >Signed-off-by: David Daney <david.daney@...ium.com>
> >---
> >  drivers/net/phy/phy_device.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> >index 0302483..55f0178 100644
> >--- a/drivers/net/phy/phy_device.c
> >+++ b/drivers/net/phy/phy_device.c
> >@@ -176,7 +176,7 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, int phy_id,
> >  	if (c45_ids)
> >  		dev->c45_ids = *c45_ids;
> >  	dev->bus = bus;
> >-	dev->dev.parent = bus->parent;
> >+	dev->dev.parent = &bus->dev;
> >  	dev->dev.bus = &mdio_bus_type;
> >  	dev->irq = bus->irq != NULL ? bus->irq[addr] : PHY_POLL;
> >  	dev_set_name(&dev->dev, PHY_ID_FMT, bus->id, addr);
> 
>    This patch makes my sh_eth driver fail to connect to PHY usinjg
> of_phy_connect(). (The ravb driver fails too but for some other
> reason.)
 
Hi Sergei

What phy is it?

Do you have phy DT properties in the MAC node?

   Andrew
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html