netdev - Re: [PATCH net] tcp: md5: fix lockdep annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151118.230338.1757197871530382209.davem@davemloft.net>
Date:	Wed, 18 Nov 2015 23:03:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, willemb@...gle.com
Subject: Re: [PATCH net] tcp: md5: fix lockdep annotation

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 18 Nov 2015 12:40:13 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> When a passive TCP is created, we eventually call tcp_md5_do_add()
> with sk pointing to the child. It is not owner by the user yet (we
> will add this socket into listener accept queue a bit later anyway)
> 
> But we do own the spinlock, so amend the lockdep annotation to avoid
> following splat :
 ...
> Fixes: a8afca0329988 ("tcp: md5: protects md5sig_info with RCU")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Willem de Bruijn <willemb@...gle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html