netdev - Re: [PATCH net-next] bpf: add show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564E169A.6070506@iogearbox.net>
Date:	Thu, 19 Nov 2015 19:36:10 +0100
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	davem@...emloft.net
CC:	alexei.starovoitov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bpf: add show_fdinfo handler for maps

On 11/19/2015 07:19 PM, Hannes Frederic Sowa wrote:
> On Thu, Nov 19, 2015, at 11:56, Daniel Borkmann wrote:
>> Add a handler for show_fdinfo() to be used by the anon-inodes
>> backend for eBPF maps, and dump the map specification there. Not
>> only useful for admins, but also it provides a minimal way to
>> compare specs from ELF vs pinned object.
>>
>> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
>
> Does it make sense to include bpf_htab->count in case of a hashmap?

It would give a sort-of only volatile view, e.g. like the map's
refcount. It would be possible to show it, but only as kind of
informative to an admin, have no strong opinion on it, though.

I think this goes rather into the direction of better debugging
interfaces for eBPF, probably makes sense think about it wrt a
general debugging/introspection framework and better dump it
there ...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html