lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Nov 2015 15:40:20 -0500 From: Tejun Heo <tj@...nel.org> To: Nina Schiff <ninasc@...com> Cc: davem@...emloft.net, daniel.wagner@...-carit.de, nhorman@...driver.com, netdev@...r.kernel.org, lizefan@...wei.com, hannes@...xchg.org, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-team@...com Subject: Re: [PATCH RESEND] cgroups: Allow dynamically changing net_classid Hello, On Fri, Nov 20, 2015 at 12:31:39PM -0800, Nina Schiff wrote: > The classid of a process is changed either when a process is moved to > or from a cgroup or when the net_cls.classid file is updated. > Previously net_cls only supported propogating these changes to the > cgroup's related sockets when a process was added or removed from the > cgroup. This means it was neccessary to remove and re-add all processes > to a cgroup in order to update its classid. This change introduces > support for doing this dynamically - i.e. when the value is changed in > the net_cls_classid file, this will also trigger an update to the > classid associated with all sockets controlled by the cgroup. > This mimics the behaviour of other cgroup subsystems. > net_prio circumvents this issue by storing an index into a table with > each socket (and so any updates to the table, don't require updating > the value associated with the socket). net_cls, however, passes the > socket the classid directly, and so this additional step is needed. > > Signed-off-by: Nina Schiff <ninasc@...com> Acked-by: Tejun Heo <tj@...nel.org> This was broken from the beginning. Thanks for fixing this. BTW, this will cause a context conflict with the cgroup2 match patches. I'll update the patchset once this lands in net-next. -- tejun -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists