netdev - Re: [PATCH] packet: Allow packets with only a header (but no payload)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5650E2DC.9060800@cogentembedded.com>
Date:	Sun, 22 Nov 2015 00:32:12 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
	netdev@...r.kernel.org
Cc:	willemb@...gle.com, edumazet@...gle.com, dborkman@...hat.com,
	davem@...emloft.net, mostrows@...thlink.net, nbd@...nwrt.org
Subject: Re: [PATCH] packet: Allow packets with only a header (but no payload)

Hello.

On 11/21/2015 3:50 AM, Martin Blumenstingl wrote:

> 9c70776 added validation for the packet size in packet_snd. This change

    Please run your patch thru scripts/checkpatch.pl -- it now enforces 
certain commit citing style.

> enforced that every packet needs a header with at least hard_header_len
> bytes  and at least one byte payload.
>
> This fixes PPPoE connections which do not have a "Service" or
> "Host-Uniq" configured (which is violating the spec, but is still
> widely used in real-world setups). Those are currently failing with the
> following message: "pppd: packet size is too short (24 <= 24)"
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html