netdev - Re: [net-next:master 48/50] net/dsa/dsa.c:783:16: error: implicit declaration of function 'gpio_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151123.151656.793660463195885617.davem@davemloft.net>
Date:	Mon, 23 Nov 2015 15:16:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fengguang.wu@...el.com
Cc:	andrew@...n.ch, kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [net-next:master 48/50] net/dsa/dsa.c:783:16: error: implicit
 declaration of function 'gpio_to_desc'

From: kbuild test robot <fengguang.wu@...el.com>
Date: Tue, 24 Nov 2015 01:34:51 +0800

> All error/warnings (new ones prefixed by >>):
> 
>    net/dsa/dsa.c: In function 'dsa_of_probe':
>>> net/dsa/dsa.c:783:16: error: implicit declaration of function 'gpio_to_desc' [-Werror=implicit-function-declaration]
>        cd->reset = gpio_to_desc(gpio);
>                    ^
>>> net/dsa/dsa.c:783:14: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>        cd->reset = gpio_to_desc(gpio);
>                  ^
>>> net/dsa/dsa.c:784:4: error: implicit declaration of function 'gpiod_direction_output' [-Werror=implicit-function-declaration]
>        gpiod_direction_output(cd->reset, 0);
>        ^
>    cc1: some warnings being treated as errors

It looks like these specific gpio interfaces are not designed such
that we get default do-nothing versions when CONFIG_GPIO is not set.

Andrew, you'll have to cope with this somehow.  Perhaps add the
missing cases to include/asm-generic/gpio.h CPP #else branch.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html