netdev - Re: [PATCH net] vrf: fix double free and memory corruption on register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151123.175337.380614330138907039.davem@davemloft.net>
Date:	Mon, 23 Nov 2015 17:53:37 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	netdev@...r.kernel.org, dsa@...ulusnetworks.com,
	shm@...ulusnetworks.com, nikolay@...ulusnetworks.com
Subject: Re: [PATCH net] vrf: fix double free and memory corruption on
 register_netdevice failure

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Sat, 21 Nov 2015 19:46:19 +0100

> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> When vrf's ->newlink is called, if register_netdevice() fails then it
> does free_netdev(), but that's also done by rtnl_newlink() so a second
> free happens and memory gets corrupted, to reproduce execute the
> following line a couple of times (1 - 5 usually is enough):
> $ for i in `seq 1 5`; do ip link add vrf: type vrf table 1; done;
> This works because we fail in register_netdevice() because of the wrong
> name "vrf:".
> 
> And here's a trace of one crash:
 ...
> Fixes: 193125dbd8eb ("net: Introduce VRF device driver")
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html