netdev - Re: [PATCH] net/ipv4/ipconfig: Rejoin broken lines in console output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151124.120024.1138985637733582287.davem@davemloft.net>
Date:	Tue, 24 Nov 2015 12:00:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	geert+renesas@...der.be
Cc:	bst@...gutronix.de, joe@...ches.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/ipv4/ipconfig: Rejoin broken lines in console
 output

From: Geert Uytterhoeven <geert+renesas@...der.be>
Date: Tue, 24 Nov 2015 14:08:23 +0100

> Commit 09605cc12c078306 ("net ipv4: use preferred log methods") replaced
> a few calls of pr_cont() after a console print without a trailing
> newline by pr_info(), causing lines to be split during IP
> autoconfiguration, like:
> 
>     .
>     ,
>      OK
>     IP-Config: Got DHCP answer from 192.168.97.254,
>     my address is 192.168.97.44
> 
> Convert these back to using pr_cont(), so it prints again:
> 
>     ., OK
>     IP-Config: Got DHCP answer from 192.168.97.254, my address is 192.168.97.44
> 
> Absorb the printing of "my address ..." into the previous call to
> pr_info(), as there's no reason to use a continuation there.
> 
> Convert one more pr_info() to print nameservers while we're at it.
> 
> Fixes: 09605cc12c078306 ("net ipv4: use preferred log methods")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html