[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20151124.142531.1333743019199613941.davem@davemloft.net>
Date: Tue, 24 Nov 2015 14:25:31 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: jakub.kicinski@...ronome.com
Cc: netdev@...r.kernel.org, simon.horman@...ronome.com,
rolf.neugebauer@...ronome.com
Subject: Re: [PATCH net-next v3 2/2] net: add driver for Netronome
NFP4000/NFP6000 NIC VFs
From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Mon, 23 Nov 2015 11:04:57 +0000
> +#ifdef CONFIG_NFP_NET_DEBUG
> +#define DEBUG
> +#endif
Do not design ad-hoc debug logging facilities locally in your driver,
and instead use the existing tree wide facilities as they were designed
to be used so that any user can get debugging logs simply by turning it
on at run time rather than having the change magic config options in
their kernel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists