[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20151123.234527.1692491746715821314.davem@davemloft.net>
Date: Mon, 23 Nov 2015 23:45:27 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: ying.xue@...driver.com
Cc: jon.maloy@...csson.com, netdev@...r.kernel.org,
tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH] tipc: avoid packets leaking on socket receive queue
From: Ying Xue <ying.xue@...driver.com>
Date: Sun, 22 Nov 2015 15:46:05 +0800
> Even if we drain receive queue thoroughly in tipc_release() after tipc
> socket is removed from rhashtable, it is possible that some packets
> are in flight because some CPU runs receiver and did rhashtable lookup
> before we removed socket. They will achieve receive queue, but nobody
> delete them at all. To avoid this leak, we register a private socket
> destructor to purge receive queue, meaning releasing packets pending
> on receive queue will be delayed until the last reference of tipc
> socket will be released.
>
> Signed-off-by: Ying Xue <ying.xue@...driver.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists