netdev - Re: [iproute PATCH v2 1/6] ipaddress: make flush command more error-tolerant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151123163115.5f8be482@xeon-e3>
Date:	Mon, 23 Nov 2015 16:31:15 -0800
From:	Stephen Hemminger <shemming@...cade.com>
To:	Phil Sutter <phil@....cc>
CC:	<netdev@...r.kernel.org>
Subject: Re: [iproute PATCH v2 1/6] ipaddress: make flush command more
 error-tolerant

On Sun,  8 Nov 2015 21:22:16 +0100
Phil Sutter <phil@....cc> wrote:

> The core issue here is that with promote_secondaries sysctl setting
> being turned off, removing the primary address implicitly removes all
> secondaries as well. Iproute is aware of this and therefore tries to
> remove all secondary addresses first to circumvent errors due to
> removing non-existent addresses. But this works only if not too many IP
> addresses are assigned to an interface, otherwise the RTM_GETADDR
> response is split up into multiple buffers. In my test-case, flushing
> more than 42 IPv4 addresses was sufficient to trigger an error:
> 
> Failed to send flush request: Cannot assign requested address
> 
> This patch fixes the issue by simply ignoring EADDRNOTAVAIL when
> flushing.
> 
> Signed-off-by: Phil Sutter <phil@....cc>

Patch does not apply to current tree. I applied an earlier patch from Neil Horman
and this supersedes this.

Please redo the patch series.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html