netdev - Re: [PATCH net] isdn: Partially revert debug format string usage clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151125.115010.1628961628426020285.davem@davemloft.net>
Date:	Wed, 25 Nov 2015 11:50:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	linux-kernel.bfrz@...chmal.in-ulm.de
Cc:	netdev@...r.kernel.org, isdn@...ux-pingi.de, keescook@...omium.org
Subject: Re: [PATCH net] isdn: Partially revert debug format string usage
 clean up

From: Christoph Biedl <linux-kernel.bfrz@...chmal.in-ulm.de>
Date: Wed, 25 Nov 2015 07:47:40 +0100

> Commit 35a4a57 ("isdn: clean up debug format string usage") introduced
> a safeguard to avoid accidential format string interpolation of data
> when calling debugl1 or HiSax_putstatus. This did however not take into
> account VHiSax_putstatus (called by HiSax_putstatus) does *not* call
> vsprintf if the head parameter is NULL - the format string is treated
> as plain text then instead. As a result, the string "%s" is processed
> literally, and the actual information is lost. This affects the isdnlog
> userspace program which stopped logging information since that commit.
> 
> So revert the HiSax_putstatus invocations to the previous state.
> 
> Fixes: 35a4a5733b0a ("isdn: clean up debug format string usage")
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Karsten Keil <isdn@...ux-pingi.de>
> Signed-off-by: Christoph Biedl <linux-kernel.bfrz@...chmal.in-ulm.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html