netdev - Re: [PATCH 3/4] staging: rtl8712: Make error handling check for failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5655CC03.8060402@gmail.com>
Date:	Wed, 25 Nov 2015 12:56:03 -0200
From:	Mauro Dreissig <mukadr@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 3/4] staging: rtl8712: Make error handling check for
 failure

On 25-11-2015 09:44, Sudip Mukherjee wrote:
> On Tue, Nov 24, 2015 at 10:19:41AM -0200, Mauro Dreissig wrote:
>> Some error handling paths are checking for success
>> instead of error on rtl871x_ioctl_rtl.c.
>>
>> Signed-off-by: Mauro Dreissig <mukadr@...il.com>
>> ---
>>  drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 239 ++++++++++++++--------------
>>  1 file changed, 121 insertions(+), 118 deletions(-)
>>
> <snip>  
>> @@ -147,13 +147,13 @@ uint oid_rt_get_rx_icv_err_hdl(struct oid_par_priv *poid_par_priv)
>>  
>>  	if (poid_par_priv->type_of_oid != QUERY_OID)
>>  		return RNDIS_STATUS_NOT_ACCEPTED;
>> -	if (poid_par_priv->information_buf_len >= sizeof(u32)) {
>> -		*(uint *)poid_par_priv->information_buf =
>> -					 adapter->recvpriv.rx_icv_err;
>> -		*poid_par_priv->bytes_rw = poid_par_priv->information_buf_len;
>> -	} else {
>> +
>> +	if (poid_par_priv->information_buf_len < sizeof(u32)) 
> 
> trailing whitespace here.
> Please always test your patch with checkpatch.
> 
> regards
> sudip
> 
This blank line is intentional, there is no trailing whitespace.

thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html