netdev - RE: [PATCH 1/2] net: fsl: Don't use NO_IRQ to check return value of irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Nov 2015 15:18:28 +0000
From:	Manoil Claudiu <claudiu.manoil@...escale.com>
To:	"David S . Miller" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>,
	Shaohui Xie <Shaohui.Xie@...escale.com>
Subject: RE: [PATCH 1/2] net: fsl: Don't use NO_IRQ to check return value of
 irq_of_parse_and_map()

>-----Original Message-----
>From: Mark Brown [mailto:broonie@...nel.org]
>Sent: Thursday, November 26, 2015 2:00 PM
>To: Manoil Claudiu-B08782 <claudiu.manoil@...escale.com>; Xie Shaohui-
>B21989 <Shaohui.Xie@...escale.com>; David S . Miller
><davem@...emloft.net>
>Cc: netdev@...r.kernel.org; Mark Brown <broonie@...nel.org>
>Subject: [PATCH 1/2] net: fsl: Don't use NO_IRQ to check return value of
>irq_of_parse_and_map()
>
>This driver can be built on arm64 but relies on NO_IRQ to check the return
>value of irq_of_parse_and_map() which fails to build on arm64 because the
>architecture does not provide a NO_IRQ. Fix this to correctly check the
>return value of irq_of_parse_and_map().
>
>Even on ARM systems where the driver was previously used the check was
>broken since on ARM NO_IRQ is -1 but irq_of_parse_and_map() returns 0 on
>error.
>
>Signed-off-by: Mark Brown <broonie@...nel.org>

Ack.
Suggesting the v2 patch below instead, adding a missing fix:
http://patchwork.ozlabs.org/patch/549126/
("[net,v2] gianfar: Don't use NO_IRQ to check return value of irq_of_parse_and_map()")

Thanks,
Claudiu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html