netdev - Re: [PATCH v3 net 6/6] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y4dj76e9.fsf@free-electrons.com>
Date:	Fri, 27 Nov 2015 17:29:18 +0100
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Marcin Wojtas <mw@...ihalf.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, davem@...emloft.net,
	linux@....linux.org.uk, sebastian.hesselbarth@...il.com,
	andrew@...n.ch, jason@...edaemon.net,
	thomas.petazzoni@...e-electrons.com, simon.guinot@...uanux.org,
	nadavh@...vell.com, alior@...vell.com, xswang@...vell.com,
	myair@...vell.com, nitroshift@...oo.com, jaz@...ihalf.com,
	tn@...ihalf.com
Subject: Re: [PATCH v3 net 6/6] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

Hi Marcin,
 
 On ven., nov. 27 2015, Marcin Wojtas <mw@...ihalf.com> wrote:

> The Ethernet controller found in the Armada 38x SoC's family support
> TCP/IP checksumming with frame sizes larger than 1600 bytes, however
> only on port 0.
>
> This commit enables it by setting 'tx-csum-limit' to 9800B in
> 'ethernet@...00' node.
>
> Signed-off-by: Marcin Wojtas <mw@...ihalf.com>
> ---
>  arch/arm/boot/dts/armada-38x.dtsi | 1 +

This commit should not be merged through the network subsystem but
through mvebu and then arm-soc.

Indeed we tried to centralize all the dts change in only one subsystem
to reduce the merge conflict.

Could you rename it in "mvebu: dts: enable IP checksum with jumbo frames
for Armada 38x on Port0" ?

I will applied on in mvebu/dts as soon as the network part will be
applied.

Thanks,

Gregory


>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index c6a0e9d..e8b7f67 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -498,6 +498,7 @@
>  				reg = <0x70000 0x4000>;
>  				interrupts-extended = <&mpic 8>;
>  				clocks = <&gateclk 4>;
> +				tx-csum-limit = <9800>;
>  				status = "disabled";
>  			};
>  
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html