netdev - Re: [PATCH v3] packet: Allow packets with only a header (but no payload)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151129.221849.57848790197671069.davem@davemloft.net>
Date:	Sun, 29 Nov 2015 22:18:49 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	martin.blumenstingl@...glemail.com
Cc:	netdev@...r.kernel.org, willemb@...gle.com, edumazet@...gle.com,
	nbd@...nwrt.org, sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH v3] packet: Allow packets with only a header (but no
 payload)

From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Date: Sun, 22 Nov 2015 17:46:09 +0100

> Commit 9c7077622dd91 ("packet: make packet_snd fail on len smaller
> than l2 header") added validation for the packet size in packet_snd.
> This change enforces that every packet needs a header (with at least
> hard_header_len bytes) plus a payload with at least one byte. Before
> this change the payload was optional.
> 
> This fixes PPPoE connections which do not have a "Service" or
> "Host-Uniq" configured (which is violating the spec, but is still
> widely used in real-world setups). Those are currently failing with the
> following message: "pppd: packet size is too short (24 <= 24)"
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html