netdev - Re: [PATCH net] af-unix: passcred support for sendpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151130.151757.498926843153934581.davem@davemloft.net>
Date:	Mon, 30 Nov 2015 15:17:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, viro@...iv.linux.org.uk,
	edumazet@...gle.com
Subject: Re: [PATCH net] af-unix: passcred support for sendpage

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Thu, 26 Nov 2015 12:08:18 +0100

> sendpage did not care about credentials at all. This could lead to
> situations in which because of fd passing between processes we could
> append data to skbs with different scm data. It is illegal to splice those
> skbs together. Instead we have to allocate a new skb and if requested
> fill out the scm details.
> 
> Fixes: 869e7c62486ec ("net: af_unix: implement stream sendpage support")
> Reported-by: Al Viro <viro@...iv.linux.org.uk>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied and queued up for -stable... but here we go with even more
complexity in arguably one of the most complex and often buggiest
protocol family implementations :-/

We seem to enjoy self-torture but putting hack on top of hack...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html